Commit ba0294df authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: sim: replace memmove() + strstrip() with skip_spaces() + strim() 



Turns out we can avoid the memmove() by using skip_spaces() and strim().
We did that in gpio-consumer, let's do it in gpio-sim.

Suggested-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent a40fe1ff

drivers/gpio/gpio-sim.c

+4 −7
Original line number Diff line number Diff line
@@ -642,16 +642,13 @@ static bool gpio_sim_device_is_live_unlocked(struct gpio_sim_device *dev) 


static char *gpio_sim_strdup_trimmed(const char *str, size_t count)

{

	char *dup, *trimmed;

	char *trimmed;



	dup = kstrndup(str, count, GFP_KERNEL);

	if (!dup)

	trimmed = kstrndup(skip_spaces(str), count, GFP_KERNEL);

	if (!trimmed)

		return NULL;



	trimmed = strstrip(dup);

	memmove(dup, trimmed, strlen(trimmed) + 1);



	return dup;

	return strim(trimmed);

}



static ssize_t gpio_sim_device_config_dev_name_show(struct config_item *item,