Commit b9d5e3e7 authored by Shivasharan S's avatar Shivasharan S Committed by Martin K. Petersen
Browse files

scsi: megaraid_sas: Replace undefined MFI_BIG_ENDIAN macro with __BIG_ENDIAN_BITFIELD macro 

MFI_BIG_ENDIAN macro used in drivers structure bitfield to check the CPU
big endianness is undefined which would break the code on big endian
machine. __BIG_ENDIAN_BITFIELD kernel macro should be used in places of
MFI_BIG_ENDIAN macro.

Link: https://lore.kernel.org/r/20200508085130.23339-1-chandrakanth.patil@broadcom.com


Fixes: a7faf81d ("scsi: megaraid_sas: Set no_write_same only for Virtual Disk")
Cc: <stable@vger.kernel.org> # v5.6+
Signed-off-by: default avatarShivasharan S <shivasharan.srikanteshwara@broadcom.com>
Signed-off-by: default avatarChandrakanth Patil <chandrakanth.patil@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 84badfab

drivers/scsi/megaraid/megaraid_sas.h

+2 −2
Original line number Diff line number Diff line
@@ -511,7 +511,7 @@ union MR_PROGRESS { 
 */

struct MR_PD_PROGRESS {

	struct {

#ifndef MFI_BIG_ENDIAN

#ifndef __BIG_ENDIAN_BITFIELD

		u32     rbld:1;

		u32     patrol:1;

		u32     clear:1;
@@ -537,7 +537,7 @@ struct MR_PD_PROGRESS { 
	};



	struct {

#ifndef MFI_BIG_ENDIAN

#ifndef __BIG_ENDIAN_BITFIELD

		u32     rbld:1;

		u32     patrol:1;

		u32     clear:1;

drivers/scsi/megaraid/megaraid_sas_fusion.h

+3 −3
Original line number Diff line number Diff line
@@ -774,7 +774,7 @@ struct MR_SPAN_BLOCK_INFO { 
struct MR_CPU_AFFINITY_MASK {

	union {

		struct {

#ifndef MFI_BIG_ENDIAN

#ifndef __BIG_ENDIAN_BITFIELD

		u8 hw_path:1;

		u8 cpu0:1;

		u8 cpu1:1;
@@ -866,7 +866,7 @@ struct MR_LD_RAID { 
	__le16     seqNum;



struct {

#ifndef MFI_BIG_ENDIAN

#ifndef __BIG_ENDIAN_BITFIELD

	u32 ldSyncRequired:1;

	u32 regTypeReqOnReadIsValid:1;

	u32 isEPD:1;
@@ -889,7 +889,7 @@ struct { 
	/* 0x30 - 0x33, Logical block size for the LD */

	u32 logical_block_length;

	struct {

#ifndef MFI_BIG_ENDIAN

#ifndef __BIG_ENDIAN_BITFIELD

	/* 0x34, P_I_EXPONENT from READ CAPACITY 16 */

	u32 ld_pi_exp:4;

	/* 0x34, LOGICAL BLOCKS PER PHYSICAL