Commit b9d15ee2 authored by Sudeep Holla's avatar Sudeep Holla
Browse files

firmware: arm_scmi: Drop empty stub for smc_mark_txdone 

The scmi protocol core driver check for non NULL mark_txdone before
invoking the same. There is no need to provide a empty stub. SMC/HVC
calls are synchronous and the call return indicates the completion.

Link: https://lore.kernel.org/r/20200327163654.13389-3-sudeep.holla@arm.com


Tested-by: default avatarPeng Fan <peng.fan@nxp.com>
Reviewed-by: default avatarPeng Fan <peng.fan@nxp.com>
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
parent 18988265

drivers/firmware/arm_scmi/smc.c

+0 −5
Original line number Original line Diff line number Diff line
@@ -114,10 +114,6 @@ static int smc_send_message(struct scmi_chan_info *cinfo, 
	return res.a0;

	return res.a0;

}

}





static void smc_mark_txdone(struct scmi_chan_info *cinfo, int ret)

{

}



static void smc_fetch_response(struct scmi_chan_info *cinfo,

static void smc_fetch_response(struct scmi_chan_info *cinfo,

			       struct scmi_xfer *xfer)

			       struct scmi_xfer *xfer)

{

{
@@ -139,7 +135,6 @@ static struct scmi_transport_ops scmi_smc_ops = { 
	.chan_setup = smc_chan_setup,

	.chan_setup = smc_chan_setup,

	.chan_free = smc_chan_free,

	.chan_free = smc_chan_free,

	.send_message = smc_send_message,

	.send_message = smc_send_message,

	.mark_txdone = smc_mark_txdone,

	.fetch_response = smc_fetch_response,

	.fetch_response = smc_fetch_response,

	.poll_done = smc_poll_done,

	.poll_done = smc_poll_done,

};

};