Commit b9ab22c2 authored by Tony Lindgren's avatar Tony Lindgren Committed by Greg Kroah-Hartman
Browse files

serial: 8250: omap: Fix freeing of resources on failed register 



If serial8250_register_8250_port() fails, the SoC can hang as the
deferred PMQoS work will still run as is not flushed and removed.

Fixes: 61929cf0 ("tty: serial: Add 8250-core based omap driver")
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20230508082014.23083-2-tony@atomide.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6d8c1fca

drivers/tty/serial/8250/8250_omap.c

+2 −0
Original line number Diff line number Diff line
@@ -1532,7 +1532,9 @@ static int omap8250_probe(struct platform_device *pdev) 
err:

	pm_runtime_dont_use_autosuspend(&pdev->dev);

	pm_runtime_put_sync(&pdev->dev);

	flush_work(&priv->qos_work);

	pm_runtime_disable(&pdev->dev);

	cpu_latency_qos_remove_request(&priv->pm_qos_request);

	return ret;

}