Commit b989f90c authored by Kalesh AP's avatar Kalesh AP Committed by Jason Gunthorpe
Browse files

RDMA/bnxt_re: Remove a redundant check inside bnxt_re_update_gid 

The NULL check inside bnxt_re_update_gid() always return false.  If
sgid_tbl->tbl is not allocated, then dev_init would have failed.

Fixes: 5fac5b1b ("RDMA/bnxt_re: Add vlan tag for untagged RoCE traffic when PFC is configured")
Link: https://lore.kernel.org/r/1684478897-12247-5-git-send-email-selvin.xavier@broadcom.com


Reviewed-by: default avatarSaravanan Vajravel <saravanan.vajravel@broadcom.com>
Reviewed-by: default avatarDamodharam Ammepalli <damodharam.ammepalli@broadcom.com>
Reviewed-by: default avatarAjit Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: default avatarSelvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent ff2e4bfd

drivers/infiniband/hw/bnxt_re/main.c

+1 −7
Original line number Diff line number Diff line
@@ -969,12 +969,6 @@ static int bnxt_re_update_gid(struct bnxt_re_dev *rdev) 
	if (!ib_device_try_get(&rdev->ibdev))

		return 0;



	if (!sgid_tbl) {

		ibdev_err(&rdev->ibdev, "QPLIB: SGID table not allocated");

		rc = -EINVAL;

		goto out;

	}



	for (index = 0; index < sgid_tbl->active; index++) {

		gid_idx = sgid_tbl->hw_id[index];
@@ -992,7 +986,7 @@ static int bnxt_re_update_gid(struct bnxt_re_dev *rdev) 
		rc = bnxt_qplib_update_sgid(sgid_tbl, &gid, gid_idx,

					    rdev->qplib_res.netdev->dev_addr);

	}

out:



	ib_device_put(&rdev->ibdev);

	return rc;

}