Commit b938cafd authored by Sean Christopherson's avatar Sean Christopherson Committed by Paolo Bonzini
Browse files

KVM: selftests: Make x86-64's register dump helpers static 



Make regs_dump() and sregs_dump() static, they're only implemented by
x86 and only used internally.

Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent f17cf567

tools/testing/selftests/kvm/lib/kvm_util_internal.h

+0 −34
Original line number Diff line number Diff line
@@ -88,40 +88,6 @@ struct vcpu *vcpu_get(struct kvm_vm *vm, uint32_t vcpuid); 
 */

void virt_dump(FILE *stream, struct kvm_vm *vm, uint8_t indent);



/*

 * Register Dump

 *

 * Input Args:

 *   stream - Output FILE stream

 *   regs   - Registers

 *   indent - Left margin indent amount

 *

 * Output Args: None

 *

 * Return: None

 *

 * Dumps the state of the registers given by @regs, to the FILE stream

 * given by @stream.

 */

void regs_dump(FILE *stream, struct kvm_regs *regs, uint8_t indent);



/*

 * System Register Dump

 *

 * Input Args:

 *   stream - Output FILE stream

 *   sregs  - System registers

 *   indent - Left margin indent amount

 *

 * Output Args: None

 *

 * Return: None

 *

 * Dumps the state of the system registers given by @sregs, to the FILE stream

 * given by @stream.

 */

void sregs_dump(FILE *stream, struct kvm_sregs *sregs, uint8_t indent);



struct userspace_mem_region *

memslot2region(struct kvm_vm *vm, uint32_t memslot);

tools/testing/selftests/kvm/lib/x86_64/processor.c

+2 −34
Original line number Diff line number Diff line
@@ -19,8 +19,7 @@ 


vm_vaddr_t exception_handlers;



void regs_dump(FILE *stream, struct kvm_regs *regs,

	       uint8_t indent)

static void regs_dump(FILE *stream, struct kvm_regs *regs, uint8_t indent)

{

	fprintf(stream, "%*srax: 0x%.16llx rbx: 0x%.16llx "

		"rcx: 0x%.16llx rdx: 0x%.16llx\n",
@@ -43,21 +42,6 @@ void regs_dump(FILE *stream, struct kvm_regs *regs, 
		regs->rip, regs->rflags);

}



/*

 * Segment Dump

 *

 * Input Args:

 *   stream  - Output FILE stream

 *   segment - KVM segment

 *   indent  - Left margin indent amount

 *

 * Output Args: None

 *

 * Return: None

 *

 * Dumps the state of the KVM segment given by @segment, to the FILE stream

 * given by @stream.

 */

static void segment_dump(FILE *stream, struct kvm_segment *segment,

			 uint8_t indent)

{
@@ -75,21 +59,6 @@ static void segment_dump(FILE *stream, struct kvm_segment *segment, 
		segment->unusable, segment->padding);

}



/*

 * dtable Dump

 *

 * Input Args:

 *   stream - Output FILE stream

 *   dtable - KVM dtable

 *   indent - Left margin indent amount

 *

 * Output Args: None

 *

 * Return: None

 *

 * Dumps the state of the KVM dtable given by @dtable, to the FILE stream

 * given by @stream.

 */

static void dtable_dump(FILE *stream, struct kvm_dtable *dtable,

			uint8_t indent)

{
@@ -99,8 +68,7 @@ static void dtable_dump(FILE *stream, struct kvm_dtable *dtable, 
		dtable->padding[0], dtable->padding[1], dtable->padding[2]);

}



void sregs_dump(FILE *stream, struct kvm_sregs *sregs,

		uint8_t indent)

static void sregs_dump(FILE *stream, struct kvm_sregs *sregs, uint8_t indent)

{

	unsigned int i;