Commit b933b6a2 authored by Michael Straube's avatar Michael Straube Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: convert ODM_ReadAndConfig_AGC_TAB_1T_8188E() to int 



The function ODM_ReadAndConfig_AGC_TAB_1T_8188E() has return type
'enum HAL_STATUS'. Convert the return type to int and use common
kernel error logic. Return 0 on success and negative values on
failure. The enum HAL_STATUS is unused now and we can remove it.

Signed-off-by: default avatarMichael Straube <straube.linux@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/20220928144323.13164-5-straube.linux@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6d09f25a

drivers/staging/r8188eu/hal/HalHWImg8188E_BB.c

+4 −5
Original line number Diff line number Diff line
@@ -173,7 +173,7 @@ static void odm_ConfigBB_AGC_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 
	udelay(1);

}



enum HAL_STATUS ODM_ReadAndConfig_AGC_TAB_1T_8188E(struct odm_dm_struct *dm_odm)

int ODM_ReadAndConfig_AGC_TAB_1T_8188E(struct odm_dm_struct *dm_odm)

{

	u32     hex         = 0;

	u32     i           = 0;
@@ -183,7 +183,6 @@ enum HAL_STATUS ODM_ReadAndConfig_AGC_TAB_1T_8188E(struct odm_dm_struct *dm_odm) 
	struct adapter *adapter =  dm_odm->Adapter;

	struct xmit_frame *pxmit_frame = NULL;

	u8 bndy_cnt = 1;

	enum HAL_STATUS rst = HAL_STATUS_SUCCESS;



	hex += ODM_ITRF_USB << 8;

	hex += ODM_CE << 16;
@@ -194,7 +193,7 @@ enum HAL_STATUS ODM_ReadAndConfig_AGC_TAB_1T_8188E(struct odm_dm_struct *dm_odm) 
		pxmit_frame = rtw_IOL_accquire_xmit_frame(adapter);

		if (!pxmit_frame) {

			pr_info("rtw_IOL_accquire_xmit_frame failed\n");

			return HAL_STATUS_FAILURE;

			return -ENOMEM;

		}

	}
@@ -245,10 +244,10 @@ enum HAL_STATUS ODM_ReadAndConfig_AGC_TAB_1T_8188E(struct odm_dm_struct *dm_odm) 
	if (biol) {

		if (!rtl8188e_IOL_exec_cmds_sync(dm_odm->Adapter, pxmit_frame, 1000, bndy_cnt)) {

			printk("~~~ %s IOL_exec_cmds Failed !!!\n", __func__);

			rst = HAL_STATUS_FAILURE;

			return -1;

		}

	}

	return rst;

	return 0;

}



/******************************************************************************

drivers/staging/r8188eu/hal/rtl8188e_phycfg.c

+1 −1
Original line number Diff line number Diff line
@@ -465,7 +465,7 @@ static int phy_BB8188E_Config_ParaFile(struct adapter *Adapter) 
	}



	/*  3. BB AGC table Initialization */

	if (HAL_STATUS_FAILURE == ODM_ReadAndConfig_AGC_TAB_1T_8188E(&pHalData->odmpriv))

	if (ODM_ReadAndConfig_AGC_TAB_1T_8188E(&pHalData->odmpriv))

		return _FAIL;



	return _SUCCESS;

drivers/staging/r8188eu/include/HalHWImg8188E_BB.h

+1 −1
Original line number Diff line number Diff line
@@ -10,7 +10,7 @@ 
*                           AGC_TAB_1T.TXT

******************************************************************************/



enum HAL_STATUS ODM_ReadAndConfig_AGC_TAB_1T_8188E(struct odm_dm_struct *odm);

int ODM_ReadAndConfig_AGC_TAB_1T_8188E(struct odm_dm_struct *odm);



/******************************************************************************

*                           PHY_REG_1T.TXT

drivers/staging/r8188eu/include/odm_types.h

+0 −5
Original line number Diff line number Diff line
@@ -6,11 +6,6 @@ 


#define	ODM_CE			0x04	/* BIT(2) */



enum HAL_STATUS {

	HAL_STATUS_SUCCESS,

	HAL_STATUS_FAILURE,

};



#define SET_TX_DESC_ANTSEL_A_88E(__ptxdesc, __value)			\

	le32p_replace_bits((__le32 *)(__ptxdesc + 8), __value, BIT(24))

#define SET_TX_DESC_ANTSEL_B_88E(__ptxdesc, __value)			\