Commit b92225b0 authored by Rob Herring's avatar Rob Herring
Browse files

dt-bindings: PCI: designware: Fix 'unevaluatedProperties' warnings 



With 'unevaluatedProperties' support implemented, there's a number of
warnings from the Designware PCIe based bindings:

Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.example.dt.yaml: pcie@1ffc000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'device_type', 'bus-range', 'ranges', '#interrupt-cells', 'interrupt-map-mask', 'interrupt-map' were unexpected)
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.example.dt.yaml: pcie@1ffc000: Unevaluated properties are not allowed ('clock-names' was unexpected)
Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@f4000000: Unevaluated properties are not allowed ('bus-range', '#address-cells', '#size-cells', 'device_type', 'ranges', 'num-lanes', '#interrupt-cells', 'interrupts', 'interrupt-names', 'interrupt-map-mask', 'interrupt-map', 'clocks', 'clock-names' were unexpected)
Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@f4000000: Unevaluated properties are not allowed ('clock-names' was unexpected)
Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@f5000000: Unevaluated properties are not allowed ('bus-range', '#address-cells', '#size-cells', 'device_type', 'phys', 'ranges', 'num-lanes', '#interrupt-cells', 'interrupts', 'interrupt-names', 'interrupt-map-mask', 'interrupt-map', 'reset-gpios', 'pcie@0,0' were unexpected)
Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@f5000000: Unevaluated properties are not allowed ('phys', 'hisilicon,clken-gpios' were unexpected)
Documentation/devicetree/bindings/pci/intel-gw-pcie.example.dt.yaml: pcie@d0e00000: Unevaluated properties are not allowed ('device_type', '#address-cells', '#size-cells', 'linux,pci-domain', 'bus-range', '#interrupt-cells', 'interrupt-map-mask', 'interrupt-map' were unexpected)
Documentation/devicetree/bindings/pci/intel-gw-pcie.example.dt.yaml: pcie@d0e00000: Unevaluated properties are not allowed ('resets', 'phys', 'phy-names', 'reset-assert-ms' were unexpected)
Documentation/devicetree/bindings/pci/rockchip-dw-pcie.example.dt.yaml: pcie@fe280000: Unevaluated properties are not allowed ('clock-names', 'msi-map', 'phys', 'phy-names', 'power-domains', 'resets', 'reset-names' were unexpected)
Documentation/devicetree/bindings/pci/samsung,exynos-pcie.example.dt.yaml: pcie@15700000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', '#interrupt-cells', 'device_type', 'bus-range', 'ranges', 'interrupt-map-mask', 'interrupt-map' were unexpected)
Documentation/devicetree/bindings/pci/samsung,exynos-pcie.example.dt.yaml: pcie@15700000: Unevaluated properties are not allowed ('clock-names', 'phys', 'vdd10-supply', 'vdd18-supply' were unexpected)
Documentation/devicetree/bindings/pci/sifive,fu740-pcie.example.dt.yaml: pcie@e00000000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', '#interrupt-cells', 'device_type', 'dma-coherent', 'bus-range', 'ranges', 'interrupts', 'interrupt-parent', 'interrupt-map-mask', 'interrupt-map', 'clock-names', 'clocks' were unexpected)
Documentation/devicetree/bindings/pci/sifive,fu740-pcie.example.dt.yaml: pcie@e00000000: Unevaluated properties are not allowed ('dma-coherent', 'clock-names', 'resets', 'pwren-gpios' were unexpected)
Documentation/devicetree/bindings/pci/socionext,uniphier-pcie-ep.example.dt.yaml: pcie-ep@66000000: Unevaluated properties are not allowed ('clock-names', 'clocks', 'reset-names', 'resets', 'phy-names', 'phys' were unexpected)
Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.example.dt.yaml: pcie@28400000: Unevaluated properties are not allowed ('clock-names' was unexpected)
Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.example.dt.yaml: pcie@28400000: Unevaluated properties are not allowed ('device_type', 'bus-range', 'num-viewport', '#address-cells', '#size-cells', '#interrupt-cells', 'ranges', 'interrupt-names', 'interrupt-map-mask', 'interrupt-map', 'max-link-speed' were unexpected)

The main problem is that snps,dw-pcie.yaml and snps,dw-pcie-ep.yaml
shouldn't set 'unevaluatedProperties: false'. Otherwise, bindings that
reference them cannot add additional properties. With that addressed,
there's a handful of other undocumented properties to add.

Cc: Xiaowei Song <songxiaowei@hisilicon.com>
Cc: Binghui Wang <wangbinghui@hisilicon.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Greentime Hu <greentime.hu@sifive.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Jingoo Han <jingoohan1@gmail.com>
Cc: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Cc: linux-pci@vger.kernel.org
Cc: linux-riscv@lists.infradead.org
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20211206194426.2470080-1-robh@kernel.org
parent 375c4b83

Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.yaml

+13 −0
Original line number Diff line number Diff line
@@ -37,6 +37,19 @@ properties: 
    minItems: 3

    maxItems: 4



  clocks: true



  clock-names:

    items:

      - const: pcie_phy_ref

      - const: pcie_aux

      - const: pcie_apb_phy

      - const: pcie_apb_sys

      - const: pcie_aclk



  phys:

    maxItems: 1



  hisilicon,clken-gpios:

    description: |

      Clock input enablement GPIOs from PCI devices like Ethernet, M.2 and

Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml

+2 −2
Original line number Diff line number Diff line
@@ -32,6 +32,8 @@ properties: 
      - const: config

      - const: mgmt



  dma-coherent: true



  num-lanes:

    const: 8
@@ -64,7 +66,6 @@ required: 
  - interrupt-parent

  - interrupt-map-mask

  - interrupt-map

  - clock-names

  - clocks

  - resets

  - pwren-gpios
@@ -104,7 +105,6 @@ examples: 
                            <0x0 0x0 0x0 0x2 &plic0 58>,

                            <0x0 0x0 0x0 0x3 &plic0 59>,

                            <0x0 0x0 0x0 0x4 &plic0 60>;

            clock-names = "pcie_aux";

            clocks = <&prci PRCI_CLK_PCIE_AUX>;

            resets = <&prci 4>;

            pwren-gpios = <&gpio 5 0>;

Documentation/devicetree/bindings/pci/snps,dw-pcie-ep.yaml

+1 −1
Original line number Diff line number Diff line
@@ -73,7 +73,7 @@ required: 
  - reg-names

  - compatible



unevaluatedProperties: false

additionalProperties: true



examples:

  - |

Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml

+1 −1
Original line number Diff line number Diff line
@@ -73,7 +73,7 @@ properties: 
      does not specify it, the driver autodetects it.

    deprecated: true



unevaluatedProperties: false

additionalProperties: true



required:

  - reg

Documentation/devicetree/bindings/pci/socionext,uniphier-pcie-ep.yaml

+1 −1
Original line number Diff line number Diff line
@@ -79,7 +79,7 @@ required: 
  - resets

  - reset-names



additionalProperties: false

unevaluatedProperties: false



examples:

  - |