Commit b91ef187 authored Mar 16, 2022 by Pavel Begunkov Committed by Jens Axboe Mar 16, 2022

io_uring: fix provided buffer return on failure for kiocb_done()



Use io_req_complete_failed() in kiocb_done(). This cleans up the code,
but also ensures that a provided buffers is correctly freed on failure.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/a4880106fcf199d5810707fe2d17126fcdf18bc4.1647481208.git.asml.silence@gmail.com


[axboe: split from previous patch]
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 3b2b78a8

fs/io_uring.c

+3 −7

Original line number	Diff line number	Diff line
		@@ -3242,14 +3242,10 @@ static void kiocb_done(struct io_kiocb *req, ssize_t ret,

		if (req->flags & REQ_F_REISSUE) {
		req->flags &= ~REQ_F_REISSUE;
		if (io_resubmit_prep(req)) {
		if (io_resubmit_prep(req))
		io_req_task_queue_reissue(req);
		} else {
		req_set_fail(req);
		req->result = ret;
		req->io_task_work.func = io_req_task_complete;
		io_req_task_work_add(req, false);
		}
		else
		io_req_task_queue_fail(req, ret);
		}
		}