Commit b8d976c7 authored by Yicong Yang's avatar Yicong Yang Committed by Suzuki K Poulose
Browse files

hwtracing: hisi_ptt: Only add the supported devices to the filters list 



The PTT device can only support the devices on the same PCIe core,
within BDF range [lower_bdf, upper_bdf]. It's not correct to assume
the devices on the root bus are from the same PCIe core, there are
cases that root ports from different PCIe core are sharing the same
bus. So check when initializing the filters list.

Fixes: ff0de066 ("hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device")
Signed-off-by: default avatarYicong Yang <yangyicong@hisilicon.com>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarSuzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20230112112201.16283-1-yangyicong@huawei.com
parent 075c7c04

drivers/hwtracing/ptt/hisi_ptt.c

+10 −0
Original line number Diff line number Diff line
@@ -356,8 +356,18 @@ static int hisi_ptt_register_irq(struct hisi_ptt *hisi_ptt) 


static int hisi_ptt_init_filters(struct pci_dev *pdev, void *data)

{

	struct pci_dev *root_port = pcie_find_root_port(pdev);

	struct hisi_ptt_filter_desc *filter;

	struct hisi_ptt *hisi_ptt = data;

	u32 port_devid;



	if (!root_port)

		return 0;



	port_devid = PCI_DEVID(root_port->bus->number, root_port->devfn);

	if (port_devid < hisi_ptt->lower_bdf ||

	    port_devid > hisi_ptt->upper_bdf)

		return 0;



	/*

	 * We won't fail the probe if filter allocation failed here. The filters