Commit b8c768cc authored by Haibo Chen's avatar Haibo Chen Committed by Bartosz Golaszewski
Browse files

gpio: pca953x: use the correct register address when regcache sync during init 



For regcache_sync_region, we need to use pca953x_recalc_addr() to get
the real register address.

Fixes: ec82d1eb ("gpio: pca953x: Zap ad-hoc reg_output cache")
Fixes: 0f25fda8 ("gpio: pca953x: Zap ad-hoc reg_direction cache")
Signed-off-by: default avatarHaibo Chen <haibo.chen@nxp.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent 2abc17a9

drivers/gpio/gpio-pca953x.c

+7 −4
Original line number Diff line number Diff line
@@ -909,15 +909,18 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, 
static int device_pca95xx_init(struct pca953x_chip *chip, u32 invert)

{

	DECLARE_BITMAP(val, MAX_LINE);

	u8 regaddr;

	int ret;



	ret = regcache_sync_region(chip->regmap, chip->regs->output,

				   chip->regs->output + NBANK(chip) - 1);

	regaddr = pca953x_recalc_addr(chip, chip->regs->output, 0);

	ret = regcache_sync_region(chip->regmap, regaddr,

				   regaddr + NBANK(chip) - 1);

	if (ret)

		goto out;



	ret = regcache_sync_region(chip->regmap, chip->regs->direction,

				   chip->regs->direction + NBANK(chip) - 1);

	regaddr = pca953x_recalc_addr(chip, chip->regs->direction, 0);

	ret = regcache_sync_region(chip->regmap, regaddr,

				   regaddr + NBANK(chip) - 1);

	if (ret)

		goto out;