Commit b8c55ce2 authored by Loic Poulain's avatar Loic Poulain Committed by David S. Miller
Browse files

net: wwan: Fix bit ops double shift 



bit operation helpers such as test_bit, clear_bit, etc take bit
position as parameter and not value. Current usage causes double
shift => BIT(BIT(0)). Fix that in wwan_core and mhi_wwan_ctrl.

Fixes: 9a44c1cc ("net: Add a WWAN subsystem")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLoic Poulain <loic.poulain@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ebbcac3d

drivers/net/wwan/mhi_wwan_ctrl.c

+5 −3
Original line number Diff line number Diff line
@@ -7,9 +7,11 @@ 
#include <linux/wwan.h>



/* MHI wwan flags */

#define MHI_WWAN_DL_CAP		BIT(0)

#define MHI_WWAN_UL_CAP		BIT(1)

#define MHI_WWAN_RX_REFILL	BIT(2)

enum mhi_wwan_flags {

	MHI_WWAN_DL_CAP,

	MHI_WWAN_UL_CAP,

	MHI_WWAN_RX_REFILL,

};



#define MHI_WWAN_MAX_MTU	0x8000

drivers/net/wwan/wwan_core.c

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ static int wwan_major; 
#define to_wwan_port(d) container_of(d, struct wwan_port, dev)



/* WWAN port flags */

#define WWAN_PORT_TX_OFF	BIT(0)

#define WWAN_PORT_TX_OFF	0



/**

 * struct wwan_device - The structure that defines a WWAN device