Commit b8b87e88 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mathieu Poirier
Browse files

remoteproc: st: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarPatrice Chotard <patrice.chotard@foss.st.com>
Link: https://lore.kernel.org/r/20230504194453.1150368-17-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
parent d1d8d442

drivers/remoteproc/st_remoteproc.c

+2 −4
Original line number Diff line number Diff line
@@ -448,7 +448,7 @@ static int st_rproc_probe(struct platform_device *pdev) 
	return ret;

}



static int st_rproc_remove(struct platform_device *pdev)

static void st_rproc_remove(struct platform_device *pdev)

{

	struct rproc *rproc = platform_get_drvdata(pdev);

	struct st_rproc *ddata = rproc->priv;
@@ -462,13 +462,11 @@ static int st_rproc_remove(struct platform_device *pdev) 
		mbox_free_channel(ddata->mbox_chan[i]);



	rproc_free(rproc);



	return 0;

}



static struct platform_driver st_rproc_driver = {

	.probe = st_rproc_probe,

	.remove = st_rproc_remove,

	.remove_new = st_rproc_remove,

	.driver = {

		.name = "st-rproc",

		.of_match_table = of_match_ptr(st_rproc_match),