Commit b8a49beb authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/valkyriefb: Use fbdev I/O helpers 



Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
	* use _IOMEM_ in commit message
v2:
	* updated to use _IOMEM_ tokens

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Acked-by: default avatarHelge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-45-tzimmermann@suse.de
parent f96c3629

drivers/video/fbdev/Kconfig

+1 −3
Original line number Diff line number Diff line
@@ -328,9 +328,7 @@ config FB_PLATINUM 
config FB_VALKYRIE

	bool "Apple \"valkyrie\" display support"

	depends on (FB = y) && (MAC || (PPC_PMAC && PPC32))

	select FB_CFB_FILLRECT

	select FB_CFB_COPYAREA

	select FB_CFB_IMAGEBLIT

	select FB_IOMEM_HELPERS

	select FB_MACMODES

	help

	  This driver supports a frame buffer for the "valkyrie" graphics

drivers/video/fbdev/valkyriefb.c

+1 −3
Original line number Diff line number Diff line
@@ -110,13 +110,11 @@ static void valkyrie_init_fix(struct fb_fix_screeninfo *fix, struct fb_info_valk 


static const struct fb_ops valkyriefb_ops = {

	.owner =	THIS_MODULE,

	FB_DEFAULT_IOMEM_OPS,

	.fb_check_var =	valkyriefb_check_var,

	.fb_set_par =	valkyriefb_set_par,

	.fb_setcolreg =	valkyriefb_setcolreg,

	.fb_blank =	valkyriefb_blank,

	.fb_fillrect	= cfb_fillrect,

	.fb_copyarea	= cfb_copyarea,

	.fb_imageblit	= cfb_imageblit,

};



/* Sets the video mode according to info->var */