Commit b88c48bf authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Guenter Roeck
Browse files

pwm: core: Get rid of unused devm_of_pwm_get() 



The devm_of_pwm_get() has recently lost its single user, drop
the dead API as well.

Note, the new code should use either plain pwm_get() or managed
devm_pwm_get() or devm_fwnode_pwm_get() APIs.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220826172642.16404-2-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 2e2aa25c

Documentation/driver-api/driver-model/devres.rst

+0 −1
Original line number Diff line number Diff line
@@ -401,7 +401,6 @@ POWER 


PWM

  devm_pwm_get()

  devm_of_pwm_get()

  devm_fwnode_pwm_get()



REGULATOR

Documentation/driver-api/pwm.rst

+1 −2
Original line number Diff line number Diff line
@@ -40,8 +40,7 @@ after usage with pwm_free(). 


New users should use the pwm_get() function and pass to it the consumer

device or a consumer name. pwm_put() is used to free the PWM device. Managed

variants of the getter, devm_pwm_get(), devm_of_pwm_get(),

devm_fwnode_pwm_get(), also exist.

variants of the getter, devm_pwm_get() and devm_fwnode_pwm_get(), also exist.



After being requested, a PWM has to be configured using::

drivers/pwm/core.c

+0 −30
Original line number Diff line number Diff line
@@ -1070,36 +1070,6 @@ struct pwm_device *devm_pwm_get(struct device *dev, const char *con_id) 
}

EXPORT_SYMBOL_GPL(devm_pwm_get);



/**

 * devm_of_pwm_get() - resource managed of_pwm_get()

 * @dev: device for PWM consumer

 * @np: device node to get the PWM from

 * @con_id: consumer name

 *

 * This function performs like of_pwm_get() but the acquired PWM device will

 * automatically be released on driver detach.

 *

 * Returns: A pointer to the requested PWM device or an ERR_PTR()-encoded

 * error code on failure.

 */

struct pwm_device *devm_of_pwm_get(struct device *dev, struct device_node *np,

				   const char *con_id)

{

	struct pwm_device *pwm;

	int ret;



	pwm = of_pwm_get(dev, np, con_id);

	if (IS_ERR(pwm))

		return pwm;



	ret = devm_add_action_or_reset(dev, devm_pwm_release, pwm);

	if (ret)

		return ERR_PTR(ret);



	return pwm;

}

EXPORT_SYMBOL_GPL(devm_of_pwm_get);



/**

 * devm_fwnode_pwm_get() - request a resource managed PWM from firmware node

 * @dev: device for PWM consumer

include/linux/pwm.h

+0 −10
Original line number Diff line number Diff line
@@ -408,8 +408,6 @@ struct pwm_device *of_pwm_get(struct device *dev, struct device_node *np, 
void pwm_put(struct pwm_device *pwm);



struct pwm_device *devm_pwm_get(struct device *dev, const char *con_id);

struct pwm_device *devm_of_pwm_get(struct device *dev, struct device_node *np,

				   const char *con_id);

struct pwm_device *devm_fwnode_pwm_get(struct device *dev,

				       struct fwnode_handle *fwnode,

				       const char *con_id);
@@ -517,14 +515,6 @@ static inline struct pwm_device *devm_pwm_get(struct device *dev, 
	return ERR_PTR(-ENODEV);

}



static inline struct pwm_device *devm_of_pwm_get(struct device *dev,

						 struct device_node *np,

						 const char *con_id)

{

	might_sleep();

	return ERR_PTR(-ENODEV);

}



static inline struct pwm_device *

devm_fwnode_pwm_get(struct device *dev, struct fwnode_handle *fwnode,

		    const char *con_id)