Commit b8800d32 authored by Artem Egorkine's avatar Artem Egorkine Committed by Takashi Iwai
Browse files

ALSA: line6: fix stack overflow in line6_midi_transmit 



Correctly calculate available space including the size of the chunk
buffer. This fixes a buffer overflow when multiple MIDI sysex
messages are sent to a PODxt device.

Signed-off-by: default avatarArtem Egorkine <arteme@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20221225105728.1153989-2-arteme@gmail.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 8508fa2e

sound/usb/line6/midi.c

+2 −1
Original line number Diff line number Diff line
@@ -44,7 +44,8 @@ static void line6_midi_transmit(struct snd_rawmidi_substream *substream) 
	int req, done;



	for (;;) {

		req = min(line6_midibuf_bytes_free(mb), line6->max_packet_size);

		req = min3(line6_midibuf_bytes_free(mb), line6->max_packet_size,

			   LINE6_FALLBACK_MAXPACKETSIZE);

		done = snd_rawmidi_transmit_peek(substream, chunk, req);



		if (done == 0)