Commit b87d8d0d authored by Heikki Krogerus's avatar Heikki Krogerus Committed by Greg Kroah-Hartman
Browse files

usb: typec: tipd: Remove dependency on "connector" child fwnode 



There is no "connector" child node available on every
platform, so the driver can't fail to probe when it's
missing.

Fixes: 57560ee9 ("usb: typec: tipd: Don't block probing of consumer of "connector" nodes")
Cc: stable@vger.kernel.org # 5.14+
Reported-by: default avatar"Regupathy, Rajaram" <rajaram.regupathy@intel.com>
Signed-off-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20210930124758.23233-1-heikki.krogerus@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4d1aa911

drivers/usb/typec/tipd/core.c

+3 −5
Original line number Diff line number Diff line
@@ -625,10 +625,6 @@ static int tps6598x_probe(struct i2c_client *client) 
	if (ret < 0)

		return ret;



	fwnode = device_get_named_child_node(&client->dev, "connector");

	if (!fwnode)

		return -ENODEV;



	/*

	 * This fwnode has a "compatible" property, but is never populated as a

	 * struct device. Instead we simply parse it to read the properties.
@@ -636,6 +632,8 @@ static int tps6598x_probe(struct i2c_client *client) 
	 * with existing DT files, we work around this by deleting any

	 * fwnode_links to/from this fwnode.

	 */

	fwnode = device_get_named_child_node(&client->dev, "connector");

	if (fwnode)

		fw_devlink_purge_absent_suppliers(fwnode);



	tps->role_sw = fwnode_usb_role_switch_get(fwnode);