Commit b87c517a authored by Miaohe Lin's avatar Miaohe Lin Committed by Linus Torvalds
Browse files

mm/vmscan: remove unneeded return value of kswapd_run() 

The return value of kswapd_run() is unused now.  Clean it up.

Link: https://lkml.kernel.org/r/20210717065911.61497-4-linmiaohe@huawei.com


Signed-off-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Cc: Alex Shi <alexs@kernel.org>
Cc: Alistair Popple <apopple@nvidia.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Shaohua Li <shli@fb.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Yu Zhao <yuzhao@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent eaad1ae7

include/linux/swap.h

+1 −1
Original line number Diff line number Diff line
@@ -408,7 +408,7 @@ static inline bool node_reclaim_enabled(void) 


extern void check_move_unevictable_pages(struct pagevec *pvec);



extern int kswapd_run(int nid);

extern void kswapd_run(int nid);

extern void kswapd_stop(int nid);



#ifdef CONFIG_SWAP

mm/vmscan.c

+2 −5
Original line number Diff line number Diff line
@@ -4434,23 +4434,20 @@ unsigned long shrink_all_memory(unsigned long nr_to_reclaim) 
 * This kswapd start function will be called by init and node-hot-add.

 * On node-hot-add, kswapd will moved to proper cpus if cpus are hot-added.

 */

int kswapd_run(int nid)

void kswapd_run(int nid)

{

	pg_data_t *pgdat = NODE_DATA(nid);

	int ret = 0;



	if (pgdat->kswapd)

		return 0;

		return;



	pgdat->kswapd = kthread_run(kswapd, pgdat, "kswapd%d", nid);

	if (IS_ERR(pgdat->kswapd)) {

		/* failure at boot is fatal */

		BUG_ON(system_state < SYSTEM_RUNNING);

		pr_err("Failed to start kswapd on node %d\n", nid);

		ret = PTR_ERR(pgdat->kswapd);

		pgdat->kswapd = NULL;

	}

	return ret;

}



/*