Commit b871656a authored by João H. Spies's avatar João H. Spies Committed by Linus Walleij
Browse files

pinctrl: rockchip: Enhance support for IRQ_TYPE_EDGE_BOTH 



Switching between falling/rising edges for IRQ_TYPE_EDGE_BOTH on pins that
require debounce can cause the device to lose events due to a desync
between pin state and irq type.

This problem is resolved by switching between IRQ_TYPE_LEVEL_LOW and
IRQ_TYPE_LEVEL_HIGH instead.

Fixes: 936ee267 ("gpio/rockchip: add driver for rockchip gpio")
Signed-off-by: default avatarJoão H. Spies <jhlspies@gmail.com>
Link: https://lore.kernel.org/r/20220808025121.110223-1-jhlspies@gmail.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 48ec7339

drivers/gpio/gpio-rockchip.c

+2 −2
Original line number Diff line number Diff line
@@ -419,11 +419,11 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) 
			goto out;

		} else {

			bank->toggle_edge_mode |= mask;

			level |= mask;

			level &= ~mask;



			/*

			 * Determine gpio state. If 1 next interrupt should be

			 * falling otherwise rising.

			 * low otherwise high.

			 */

			data = readl(bank->reg_base + bank->gpio_regs->ext_port);

			if (data & mask)