Commit b850b7a8 authored by Ang Tien Sung's avatar Ang Tien Sung Committed by Greg Kroah-Hartman
Browse files

firmware: stratix10-svc: add missing callback parameter on RSU 

Fix a bug whereby, the return response of parameter a1 from an
SMC call is not properly set to the callback data during an
INTEL_SIP_SMC_RSU_ERROR command.

Link: https://lore.kernel.org/lkml/20220216081513.28319-1-tien.sung.ang@intel.com


Fixes: 6b50d882 ("firmware: add remote status update client support")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarAng Tien Sung <tien.sung.ang@intel.com>
Signed-off-by: default avatarDinh Nguyen <dinguyen@kernel.org>
Link: https://lore.kernel.org/r/20220223144146.399263-1-dinguyen@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8c8ce95b

drivers/firmware/stratix10-svc.c

+1 −1
Original line number Diff line number Diff line
@@ -483,7 +483,7 @@ static int svc_normal_to_secure_thread(void *data) 
		case INTEL_SIP_SMC_RSU_ERROR:

			pr_err("%s: STATUS_ERROR\n", __func__);

			cbdata->status = BIT(SVC_STATUS_ERROR);

			cbdata->kaddr1 = NULL;

			cbdata->kaddr1 = &res.a1;

			cbdata->kaddr2 = NULL;

			cbdata->kaddr3 = NULL;

			pdata->chan->scl->receive_cb(pdata->chan->scl, cbdata);