Commit b8457726 authored by Mario Limonciello's avatar Mario Limonciello Committed by Hans de Goede
Browse files

platform/x86/amd: pmc: Don't try to read SMU version on Picasso 

Picasso doesn't support the command in the uPEP mailbox to try to
read the SMU version.

Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2449


Fixes: f6045de1 ("platform/x86: amd-pmc: Export Idlemask values based on the APU")
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20230409185348.556161-2-Shyam-sundar.S-k@amd.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent aec8298c

drivers/platform/x86/amd/pmc.c

+3 −0
Original line number Diff line number Diff line
@@ -403,6 +403,9 @@ static int amd_pmc_get_smu_version(struct amd_pmc_dev *dev) 
	int rc;

	u32 val;



	if (dev->cpu_id == AMD_CPU_ID_PCO)

		return -ENODEV;



	rc = amd_pmc_send_cmd(dev, 0, &val, SMU_MSG_GETSMUVERSION, 1);

	if (rc)

		return rc;