Commit b7ba6cfa authored by Yingjie Wang's avatar Yingjie Wang Committed by Jakub Kicinski
Browse files

octeontx2-af: Fix missing check bugs in rvu_cgx.c 



In rvu_mbox_handler_cgx_mac_addr_get()
and rvu_mbox_handler_cgx_mac_addr_set(),
the msg is expected only from PFs that are mapped to CGX LMACs.
It should be checked before mapping,
so we add the is_cgx_config_permitted() in the functions.

Fixes: 96be2e0d ("octeontx2-af: Support for MAC address filters in CGX")
Signed-off-by: default avatarYingjie Wang <wangyingjie55@126.com>
Reviewed-by: default avatarGeetha <sowjanya&lt;gakula@marvell.com>
Link: https://lore.kernel.org/r/1610719804-35230-1-git-send-email-wangyingjie55@126.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 14662050

drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c

+6 −0
Original line number Diff line number Diff line
@@ -469,6 +469,9 @@ int rvu_mbox_handler_cgx_mac_addr_set(struct rvu *rvu, 
	int pf = rvu_get_pf(req->hdr.pcifunc);

	u8 cgx_id, lmac_id;



	if (!is_cgx_config_permitted(rvu, req->hdr.pcifunc))

		return -EPERM;



	rvu_get_cgx_lmac_id(rvu->pf2cgxlmac_map[pf], &cgx_id, &lmac_id);



	cgx_lmac_addr_set(cgx_id, lmac_id, req->mac_addr);
@@ -485,6 +488,9 @@ int rvu_mbox_handler_cgx_mac_addr_get(struct rvu *rvu, 
	int rc = 0, i;

	u64 cfg;



	if (!is_cgx_config_permitted(rvu, req->hdr.pcifunc))

		return -EPERM;



	rvu_get_cgx_lmac_id(rvu->pf2cgxlmac_map[pf], &cgx_id, &lmac_id);



	rsp->hdr.rc = rc;