Commit b7b862d7 authored by Vaibhav Gupta's avatar Vaibhav Gupta Committed by Martin K. Petersen
Browse files

scsi: arcmsr: Drop PCI wakeup calls from .resume 

The driver calls pci_enable_wake(...., false) in arcmsr_resume(), and there
is no corresponding pci_enable_wake(...., true) in arcmsr_suspend().
Either it should do enable-wake the device in .suspend() or should not
invoke pci_enable_wake() at all.

Concluding that this driver doesn't support enable-wake and PCI core calls
pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
arcmsr_resume().

Link: https://lore.kernel.org/r/20201102164730.324035-9-vaibhavgupta40@gmail.com


Signed-off-by: default avatarVaibhav Gupta <vaibhavgupta40@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent ec199a8d

drivers/scsi/arcmsr/arcmsr_hba.c

+0 −1
Original line number Diff line number Diff line
@@ -1160,7 +1160,6 @@ static int arcmsr_resume(struct pci_dev *pdev) 
		(struct AdapterControlBlock *)host->hostdata;



	pci_set_power_state(pdev, PCI_D0);

	pci_enable_wake(pdev, PCI_D0, 0);

	pci_restore_state(pdev);

	if (pci_enable_device(pdev)) {

		pr_warn("%s: pci_enable_device error\n", __func__);