Unverified Commit b7b71b8c authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: SOF: Intel: hda-dai: mark functions as __maybe_unused 



hda_dai_hw_params, hda_dai_trigger(), hda_dai_hw_free are currently
only used for HDaudio codec support, but will be reused for
SSP/DMIC/SoundWire in the LunarLake/ACE2.x case. To avoid 'defined but
not used' errors or added complexity in Kconfig, mark all these
functions as __maybe_used.

When SSP/DMIC/SoundWire are added, some of these changes may be
reverted. For now this avoids compilation warnings.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarPéter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarRander Wang <rander.wang@intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20230512181702.117483-8-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent caf7ad84

sound/soc/sof/intel/hda-dai.c

+7 −5
Original line number Diff line number Diff line
@@ -206,7 +206,8 @@ static int hda_link_dma_hw_params(struct snd_pcm_substream *substream, 
	return 0;

}



static int hda_dai_hw_free(struct snd_pcm_substream *substream, struct snd_soc_dai *cpu_dai)

static int __maybe_unused hda_dai_hw_free(struct snd_pcm_substream *substream,

					  struct snd_soc_dai *cpu_dai)

{

	const struct hda_dai_widget_dma_ops *ops = hda_dai_get_ops(substream, cpu_dai);

	struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
@@ -226,7 +227,7 @@ static int hda_dai_hw_free(struct snd_pcm_substream *substream, struct snd_soc_d 
	return hda_link_dma_cleanup(substream, hext_stream, cpu_dai, codec_dai);

}



static int hda_dai_hw_params(struct snd_pcm_substream *substream,

static int __maybe_unused hda_dai_hw_params(struct snd_pcm_substream *substream,

					    struct snd_pcm_hw_params *params,

					    struct snd_soc_dai *dai)

{
@@ -263,7 +264,8 @@ static int hda_dai_hw_params(struct snd_pcm_substream *substream, 
 * In contrast to IPC3, the dai trigger in IPC4 mixes pipeline state changes

 * (over IPC channel) and DMA state change (direct host register changes).

 */

static int hda_dai_trigger(struct snd_pcm_substream *substream, int cmd, struct snd_soc_dai *dai)

static int __maybe_unused hda_dai_trigger(struct snd_pcm_substream *substream, int cmd,

					  struct snd_soc_dai *dai)

{

	const struct hda_dai_widget_dma_ops *ops = hda_dai_get_ops(substream, dai);

	struct hdac_ext_stream *hext_stream;