Commit b7a0a63f authored by Sven Peter's avatar Sven Peter Committed by Greg Kroah-Hartman
Browse files

usb: typec: tipd: Remove WARN_ON in tps6598x_block_read 



Calling tps6598x_block_read with a higher than allowed len can be
handled by just returning an error. There's no need to crash systems
with panic-on-warn enabled.

Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarSven Peter <sven@svenpeter.dev>
Link: https://lore.kernel.org/r/20210914140235.65955-3-sven@svenpeter.dev


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ac588dfa

drivers/usb/typec/tipd/core.c

+1 −1
Original line number Diff line number Diff line
@@ -117,7 +117,7 @@ tps6598x_block_read(struct tps6598x *tps, u8 reg, void *val, size_t len) 
	u8 data[TPS_MAX_LEN + 1];

	int ret;



	if (WARN_ON(len + 1 > sizeof(data)))

	if (len + 1 > sizeof(data))

		return -EINVAL;



	if (!tps->i2c_protocol)