Commit b767ca65 authored by Dave Ertman's avatar Dave Ertman Committed by Tony Nguyen
Browse files

ice: Fix link broken after GLOBR reset 



After a GLOBR, the link was broken so that a link
up situation was being seen as a link down.

The problem was that the rebuild process was updating
the port_info link status without doing any of the
other things that need to be done when link changes.

This was causing the port_info struct to have current
"UP" information so that any further UP interrupts
were skipped as redundant.

The rebuild flow should *not* be updating the port_info
struct link information, so eliminate this and leave
it to the link event handling code.

Signed-off-by: default avatarDave Ertman <david.m.ertman@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 7d9c9b79

drivers/net/ethernet/intel/ice/ice_main.c

+0 −4
Original line number Diff line number Diff line
@@ -5913,10 +5913,6 @@ static void ice_rebuild(struct ice_pf *pf, enum ice_reset_req reset_type) 
	if (err)

		goto err_sched_init_port;



	err = ice_update_link_info(hw->port_info);

	if (err)

		dev_err(dev, "Get link status error %d\n", err);



	/* start misc vector */

	err = ice_req_irq_msix_misc(pf);

	if (err) {