Commit b76521f6 authored by Kelvin Cao's avatar Kelvin Cao Committed by Bjorn Helgaas
Browse files

PCI/switchtec: Declare local state_names[] as static 

The local state_names[] array is constant and need not be allocated and
populated each time we enter stuser_set_state().  Declare it as static.

See the link below for the discussion.

  https://lore.kernel.org/r/20211014141859.11444-1-kelvin.cao@microchip.com/



[bhelgaas: simplify commit log]
Suggested-by: default avatarKrzysztof Wilczyński <kw@linux.com>
Link: https://lore.kernel.org/r/20211119003803.2333-3-kelvin.cao@microchip.com


Signed-off-by: default avatarKelvin Cao <kelvin.cao@microchip.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarLogan Gunthorpe <logang@deltatee.com>
parent bb17b158

drivers/pci/switch/switchtec.c

+1 −1
Original line number Diff line number Diff line
@@ -122,7 +122,7 @@ static void stuser_set_state(struct switchtec_user *stuser, 
{

	/* requires the mrpc_mutex to already be held when called */



	const char * const state_names[] = {

	static const char * const state_names[] = {

		[MRPC_IDLE] = "IDLE",

		[MRPC_QUEUED] = "QUEUED",

		[MRPC_RUNNING] = "RUNNING",