Commit b75dacaa authored by Yucong Sun's avatar Yucong Sun Committed by Andrii Nakryiko
Browse files

selftests/bpf: Fix crash in core_reloc when bpftool btfgen fails 



Avoid unnecessary goto cleanup, as there is nothing to clean up.

Signed-off-by: default avatarYucong Sun <fallentree@fb.com>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20220217180210.2981502-1-fallentree@fb.com
parent b38101c5

tools/testing/selftests/bpf/prog_tests/core_reloc.c

+2 −2
Original line number Diff line number Diff line
@@ -888,12 +888,12 @@ static void run_core_reloc_tests(bool use_btfgen) 


			fd = mkstemp(btf_file);

			if (!ASSERT_GE(fd, 0, "btf_tmp"))

				goto cleanup;

				continue;

			close(fd); /* we only need the path */

			err = run_btfgen(test_case->btf_src_file, btf_file,

					 test_case->bpf_obj_file);

			if (!ASSERT_OK(err, "run_btfgen"))

				goto cleanup;

				continue;



			test_case->btf_src_file = btf_file;

		}