Commit b71d0987 authored by Vladimir Oltean's avatar Vladimir Oltean Committed by David S. Miller
Browse files

net: dsa: return -EOPNOTSUPP when driver does not implement .port_lag_join 



The DSA core has a layered structure, and even though we end up
returning 0 (success) to user space when setting a bonding/team upper
that can't be offloaded, some parts of the framework actually need to
know that we couldn't offload that.

For example, if dsa_switch_lag_join returns 0 as it currently does,
dsa_port_lag_join has no way to tell a successful offload from a
software fallback, and it will call dsa_port_bridge_join afterwards.
Then we'll think we're offloading the bridge master of the LAG, when in
fact we're not even offloading the LAG. In turn, this will make us set
skb->offload_fwd_mark = true, which is incorrect and the bridge doesn't
like it.

Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e6a16043

net/dsa/switch.c

+2 −2
Original line number Diff line number Diff line
@@ -427,7 +427,7 @@ static int dsa_switch_lag_join(struct dsa_switch *ds, 
						   info->port, info->lag,

						   info->info);



	return 0;

	return -EOPNOTSUPP;

}



static int dsa_switch_lag_leave(struct dsa_switch *ds,
@@ -440,7 +440,7 @@ static int dsa_switch_lag_leave(struct dsa_switch *ds, 
		return ds->ops->crosschip_lag_leave(ds, info->sw_index,

						    info->port, info->lag);



	return 0;

	return -EOPNOTSUPP;

}



static int dsa_switch_mdb_add(struct dsa_switch *ds,