Unverified Commit b7059927 authored by Linus Walleij's avatar Linus Walleij Committed by Mark Brown
Browse files

regmap: check right noinc bounds in debug print 



We were using the wrong bound in the debug prints: this
needs to be the number of elements, not the number of bytes,
since we're indexing into an element-size typed array.

Fixes: c20cc099 ("regmap: Support accelerated noinc operations")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20220823135700.265019-1-linus.walleij@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 026c99b5

drivers/base/regmap/regmap.c

+2 −2
Original line number Diff line number Diff line
@@ -2193,7 +2193,7 @@ static int regmap_noinc_readwrite(struct regmap *map, unsigned int reg, 


	if (!ret && regmap_should_log(map)) {

		dev_info(map->dev, "%x %s [", reg, write ? "<=" : "=>");

		for (i = 0; i < val_len; i++) {

		for (i = 0; i < val_count; i++) {

			switch (val_bytes) {

			case 1:

				pr_cont("%x", u8p[i]);
@@ -2212,7 +2212,7 @@ static int regmap_noinc_readwrite(struct regmap *map, unsigned int reg, 
			default:

				break;

			}

			if (i == (val_len - 1))

			if (i == (val_count - 1))

				pr_cont("]\n");

			else

				pr_cont(",");