Commit b6f56cdd authored by Daniel Golle's avatar Daniel Golle Committed by David S. Miller
Browse files

net: dsa: mt7530: make some noise if register read fails 



Simply returning the negative error value instead of the read value
doesn't seem like a good idea. Return 0 instead and add WARN_ON_ONCE(1)
so this kind of error will not go unnoticed.

Suggested-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDaniel Golle <daniel@makrotopia.org>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 56b029dd

drivers/net/dsa/mt7530.c

+2 −1
Original line number Diff line number Diff line
@@ -224,9 +224,10 @@ mt7530_mii_read(struct mt7530_priv *priv, u32 reg) 
	/* MT7530 uses 31 as the pseudo port */

	ret = bus->write(bus, 0x1f, 0x1f, page);

	if (ret < 0) {

		WARN_ON_ONCE(1);

		dev_err(&bus->dev,

			"failed to read mt7530 register\n");

		return ret;

		return 0;

	}



	lo = bus->read(bus, 0x1f, r);