Commit b68ea4c2 authored by Yangtao Li's avatar Yangtao Li Committed by Viresh Kumar
Browse files

cpufreq: mediatek-hw: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarYangtao Li <frank.li@vivo.com>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent 1d61b32e

drivers/cpufreq/mediatek-cpufreq-hw.c

+2 −4
Original line number Diff line number Diff line
@@ -316,11 +316,9 @@ static int mtk_cpufreq_hw_driver_probe(struct platform_device *pdev) 
	return ret;

}



static int mtk_cpufreq_hw_driver_remove(struct platform_device *pdev)

static void mtk_cpufreq_hw_driver_remove(struct platform_device *pdev)

{

	cpufreq_unregister_driver(&cpufreq_mtk_hw_driver);



	return 0;

}



static const struct of_device_id mtk_cpufreq_hw_match[] = {
@@ -331,7 +329,7 @@ MODULE_DEVICE_TABLE(of, mtk_cpufreq_hw_match); 


static struct platform_driver mtk_cpufreq_hw_driver = {

	.probe = mtk_cpufreq_hw_driver_probe,

	.remove = mtk_cpufreq_hw_driver_remove,

	.remove_new = mtk_cpufreq_hw_driver_remove,

	.driver = {

		.name = "mtk-cpufreq-hw",

		.of_match_table = mtk_cpufreq_hw_match,