Commit b66f8684 authored by Hans de Goede's avatar Hans de Goede Committed by Rafael J. Wysocki
Browse files

ACPI: EC: Mark the ec_sys write_support param as module_param_hw() 



Using write_support=1 with the ec_sys module changes the mode of the
"io" debugfs file to 0600. This will cause any attempts to access it under
a kernel in lockdown mode to return -EPERM, which makes the entire ec_sys
module unusable.

Use the special module_param_hw() macro for module parameters which
may not be used while in lockdown mode, to avoid this.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent befd9b5b

drivers/acpi/ec_sys.c

+1 −1
Original line number Diff line number Diff line
@@ -19,7 +19,7 @@ MODULE_DESCRIPTION("ACPI EC sysfs access driver"); 
MODULE_LICENSE("GPL");



static bool write_support;

module_param(write_support, bool, 0644);

module_param_hw(write_support, bool, other, 0644);

MODULE_PARM_DESC(write_support, "Dangerous, reboot and removal of battery may "

		 "be needed.");