Commit b630749f authored by Mateusz Nosek's avatar Mateusz Nosek Committed by Linus Torvalds
Browse files

mm/page_alloc.c: clean code by removing unnecessary initialization 



Previously variable 'tmp' was initialized, but was not read later before
reassigning.  So the initialization can be removed.

[akpm@linux-foundation.org: remove `tmp' altogether]

Signed-off-by: default avatarMateusz Nosek <mateusznosek0@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Link: https://lkml.kernel.org/r/20200904132422.17387-1-mateusznosek0@gmail.com


Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6a654e36

mm/page_alloc.c

+1 −3
Original line number Diff line number Diff line
@@ -5651,7 +5651,6 @@ static int find_next_best_node(int node, nodemask_t *used_node_mask) 
	int n, val;

	int min_val = INT_MAX;

	int best_node = NUMA_NO_NODE;

	const struct cpumask *tmp = cpumask_of_node(0);



	/* Use the local node if we haven't already */

	if (!node_isset(node, *used_node_mask)) {
@@ -5672,8 +5671,7 @@ static int find_next_best_node(int node, nodemask_t *used_node_mask) 
		val += (n < node);



		/* Give preference to headless and unused nodes */

		tmp = cpumask_of_node(n);

		if (!cpumask_empty(tmp))

		if (!cpumask_empty(cpumask_of_node(n)))

			val += PENALTY_FOR_NODE_WITH_CPUS;



		/* Slight preference for less loaded node */