Commit b62e71be authored by Chao Yu's avatar Chao Yu Committed by Jaegeuk Kim
Browse files

f2fs: support errors=remount-ro|continue|panic mountoption 



This patch supports errors=remount-ro|continue|panic mount option
for f2fs.

f2fs behaves as below in three different modes:
mode			continue	remount-ro	panic
access ops		normal		noraml		N/A
syscall errors		-EIO		-EROFS		N/A
mount option		rw		ro		N/A
pending dir write	keep		keep		N/A
pending non-dir write	drop		keep		N/A
pending node write	drop		keep		N/A
pending meta write	keep		keep		N/A

By default it uses "continue" mode.

[Yangtao helps to clean up function's name]
Signed-off-by: default avatarYangtao Li <frank.li@vivo.com>
Signed-off-by: default avatarChao Yu <chao@kernel.org>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent ac9a7868

Documentation/filesystems/f2fs.rst

+16 −0
Original line number Diff line number Diff line
@@ -351,6 +351,22 @@ age_extent_cache Enable an age extent cache based on rb-tree. It records 
			 data block update frequency of the extent per inode, in

			 order to provide better temperature hints for data block

			 allocation.

errors=%s		 Specify f2fs behavior on critical errors. This supports modes:

			 "panic", "continue" and "remount-ro", respectively, trigger

			 panic immediately, continue without doing anything, and remount

			 the partition in read-only mode. By default it uses "continue"

			 mode.

			 ====================== =============== =============== ========

			 mode			continue	remount-ro	panic

			 ====================== =============== =============== ========

			 access ops		normal		noraml		N/A

			 syscall errors		-EIO		-EROFS		N/A

			 mount option		rw		ro		N/A

			 pending dir write	keep		keep		N/A

			 pending non-dir write	drop		keep		N/A

			 pending node write	drop		keep		N/A

			 pending meta write	keep		keep		N/A

			 ====================== =============== =============== ========

======================== ============================================================



Debugfs Entries

fs/f2fs/checkpoint.c

+2 −5
Original line number Diff line number Diff line
@@ -30,12 +30,9 @@ void f2fs_stop_checkpoint(struct f2fs_sb_info *sbi, bool end_io, 
						unsigned char reason)

{

	f2fs_build_fault_attr(sbi, 0, 0);

	set_ckpt_flags(sbi, CP_ERROR_FLAG);

	if (!end_io) {

	if (!end_io)

		f2fs_flush_merged_writes(sbi);



		f2fs_handle_stop(sbi, reason);

	}

	f2fs_handle_critical_error(sbi, reason, end_io);

}



/*

fs/f2fs/data.c

+4 −0
Original line number Diff line number Diff line
@@ -2807,6 +2807,10 @@ int f2fs_write_single_data_page(struct page *page, int *submitted, 
		if (S_ISDIR(inode->i_mode) &&

				!is_sbi_flag_set(sbi, SBI_IS_CLOSE))

			goto redirty_out;



		/* keep data pages in remount-ro mode */

		if (F2FS_OPTION(sbi).errors == MOUNT_ERRORS_READONLY)

			goto redirty_out;

		goto out;

	}

fs/f2fs/f2fs.h

+17 −3
Original line number Diff line number Diff line
@@ -162,6 +162,7 @@ struct f2fs_mount_info { 
	int fs_mode;			/* fs mode: LFS or ADAPTIVE */

	int bggc_mode;			/* bggc mode: off, on or sync */

	int memory_mode;		/* memory mode */

	int errors;			/* errors parameter */

	int discard_unit;		/*

					 * discard command's offset/size should

					 * be aligned to this unit: block,
@@ -1370,6 +1371,12 @@ enum { 
	MEMORY_MODE_LOW,	/* memory mode for low memry devices */

};



enum errors_option {

	MOUNT_ERRORS_READONLY,	/* remount fs ro on errors */

	MOUNT_ERRORS_CONTINUE,	/* continue on errors */

	MOUNT_ERRORS_PANIC,	/* panic on errors */

};



static inline int f2fs_test_bit(unsigned int nr, char *addr);

static inline void f2fs_set_bit(unsigned int nr, char *addr);

static inline void f2fs_clear_bit(unsigned int nr, char *addr);
@@ -1721,8 +1728,14 @@ struct f2fs_sb_info { 


	struct workqueue_struct *post_read_wq;	/* post read workqueue */



	/*

	 * If we are in irq context, let's update error information into

	 * on-disk superblock in the work.

	 */

	struct work_struct s_error_work;

	unsigned char errors[MAX_F2FS_ERRORS];		/* error flags */

	spinlock_t error_lock;			/* protect errors array */

	unsigned char stop_reason[MAX_STOP_REASON];	/* stop reason */

	spinlock_t error_lock;			/* protect errors/stop_reason array */

	bool error_dirty;			/* errors of sb is dirty */



	struct kmem_cache *inline_xattr_slab;	/* inline xattr entry */
@@ -3541,8 +3554,9 @@ int f2fs_enable_quota_files(struct f2fs_sb_info *sbi, bool rdonly); 
int f2fs_quota_sync(struct super_block *sb, int type);

loff_t max_file_blocks(struct inode *inode);

void f2fs_quota_off_umount(struct super_block *sb);

void f2fs_handle_stop(struct f2fs_sb_info *sbi, unsigned char reason);

void f2fs_save_errors(struct f2fs_sb_info *sbi, unsigned char flag);

void f2fs_handle_critical_error(struct f2fs_sb_info *sbi, unsigned char reason,

							bool irq_context);

void f2fs_handle_error(struct f2fs_sb_info *sbi, unsigned char error);

int f2fs_commit_super(struct f2fs_sb_info *sbi, bool recover);

int f2fs_sync_fs(struct super_block *sb, int sync);

fs/f2fs/file.c

+0 −5
Original line number Diff line number Diff line
@@ -2225,7 +2225,6 @@ static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg) 
				ret = 0;

				f2fs_stop_checkpoint(sbi, false,

						STOP_CP_REASON_SHUTDOWN);

				set_sbi_flag(sbi, SBI_IS_SHUTDOWN);

				trace_f2fs_shutdown(sbi, in, ret);

			}

			return ret;
@@ -2238,7 +2237,6 @@ static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg) 
		if (ret)

			goto out;

		f2fs_stop_checkpoint(sbi, false, STOP_CP_REASON_SHUTDOWN);

		set_sbi_flag(sbi, SBI_IS_SHUTDOWN);

		thaw_bdev(sb->s_bdev);

		break;

	case F2FS_GOING_DOWN_METASYNC:
@@ -2247,16 +2245,13 @@ static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg) 
		if (ret)

			goto out;

		f2fs_stop_checkpoint(sbi, false, STOP_CP_REASON_SHUTDOWN);

		set_sbi_flag(sbi, SBI_IS_SHUTDOWN);

		break;

	case F2FS_GOING_DOWN_NOSYNC:

		f2fs_stop_checkpoint(sbi, false, STOP_CP_REASON_SHUTDOWN);

		set_sbi_flag(sbi, SBI_IS_SHUTDOWN);

		break;

	case F2FS_GOING_DOWN_METAFLUSH:

		f2fs_sync_meta_pages(sbi, META, LONG_MAX, FS_META_IO);

		f2fs_stop_checkpoint(sbi, false, STOP_CP_REASON_SHUTDOWN);

		set_sbi_flag(sbi, SBI_IS_SHUTDOWN);

		break;

	case F2FS_GOING_DOWN_NEED_FSCK:

		set_sbi_flag(sbi, SBI_NEED_FSCK);