Commit b626871a authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Greg Kroah-Hartman
Browse files

usb: atm: Use struct_size() helper 

Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worse scenario, could lead to heap overflows.

Link: https://github.com/KSPP/linux/issues/160


Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20210928233935.GA299525@embeddedor


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c1baf6c5

drivers/usb/atm/usbatm.c

+3 −1
Original line number Diff line number Diff line
@@ -1015,9 +1015,11 @@ int usbatm_usb_probe(struct usb_interface *intf, const struct usb_device_id *id, 
	int error = -ENOMEM;

	int i, length;

	unsigned int maxpacket, num_packets;

	size_t size;



	/* instance init */

	instance = kzalloc(sizeof(*instance) + sizeof(struct urb *) * (num_rcv_urbs + num_snd_urbs), GFP_KERNEL);

	size = struct_size(instance, urbs, num_rcv_urbs + num_snd_urbs);

	instance = kzalloc(size, GFP_KERNEL);

	if (!instance)

		return -ENOMEM;