Unverified Commit b60cf8e5 authored by Conor Dooley's avatar Conor Dooley Committed by Palmer Dabbelt
Browse files

dt-bindings: riscv: fix SiFive l2-cache's cache-sets



Fix device tree schema validation error messages for the SiFive
Unmatched: ' cache-sets:0:0: 1024 was expected'.

The existing bindings allow for just 1024 cache-sets but the fu740 on
Unmatched the has 2048 cache-sets. The ISA itself permits any arbitrary
power of two, however this is not supported by dt-schema. The RTL for
the IP, to which the number of cache-sets is a tunable parameter, has
been released publicly so speculatively adding a small number of
"reasonable" values seems unwise also.

Instead, as the binding only supports two distinct controllers: add 2048
and explicitly lock it to the fu740's l2 cache while limiting 1024 to
the l2 cache on the fu540.

Fixes: af951c3a ("dt-bindings: riscv: Update l2 cache DT documentation to add support for SiFive FU740")
Reported-by: default avatarAtul Khare <atulkhare@rivosinc.com>
Signed-off-by: default avatarConor Dooley <conor.dooley@microchip.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20220803185359.942928-1-mail@conchuod.ie


Signed-off-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
parent 87df2b5c
Loading
Loading
Loading
Loading
+5 −1
Original line number Diff line number Diff line
@@ -46,7 +46,7 @@ properties:
    const: 2

  cache-sets:
    const: 1024
    enum: [1024, 2048]

  cache-size:
    const: 2097152
@@ -84,6 +84,8 @@ then:
      description: |
        Must contain entries for DirError, DataError and DataFail signals.
      maxItems: 3
    cache-sets:
      const: 1024

else:
  properties:
@@ -91,6 +93,8 @@ else:
      description: |
        Must contain entries for DirError, DataError, DataFail, DirFail signals.
      minItems: 4
    cache-sets:
      const: 2048

additionalProperties: false