Commit b6011966 authored by Pan Bian's avatar Pan Bian Committed by Jakub Kicinski
Browse files

chtls: Fix potential resource leak 



The dst entry should be released if no neighbour is found. Goto label
free_dst to fix the issue. Besides, the check of ndev against NULL is
redundant.

Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Link: https://lore.kernel.org/r/20210121145738.51091-1-bianpan2016@163.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent cf3c4663

drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c

+3 −4
Original line number Diff line number Diff line
@@ -1158,11 +1158,9 @@ static struct sock *chtls_recv_sock(struct sock *lsk, 
#endif

	}

	if (!n || !n->dev)

		goto free_sk;

		goto free_dst;



	ndev = n->dev;

	if (!ndev)

		goto free_dst;

	if (is_vlan_dev(ndev))

		ndev = vlan_dev_real_dev(ndev);
@@ -1250,6 +1248,7 @@ static struct sock *chtls_recv_sock(struct sock *lsk, 
free_csk:

	chtls_sock_release(&csk->kref);

free_dst:

	if (n)

		neigh_release(n);

	dst_release(dst);

free_sk: