Commit b599a5d9 authored by James Clark's avatar James Clark Committed by Junhao He
Browse files

perf: test: Speed up running brstack test on an Arm model 

maillist inclusion
category: feature
bugzilla: https://gitee.com/openeuler/kernel/issues/I8EC9K
CVE: NA

Reference: https://lore.kernel.org/linux-arm-kernel/20240613061731.3109448-1-anshuman.khandual@arm.com/



--------------------------------

The test runs quite slowly in the model, so replace "xargs -n1" with
"tr ' ' '\n'" which does the same thing but in single digit minutes
instead of double digit minutes.

Also reduce the number of loops in the test application. Unfortunately
this causes intermittent failures on x86, presumably because the
sampling interval is too big to pickup any loops, so keep it the same
there.

Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarJames Clark <james.clark@arm.com>
Signed-off-by: default avatarAnshuman Khandual <anshuman.khandual@arm.com>
Signed-off-by: default avatarJunhao He <hejunhao3@huawei.com>
parent b8e637bf

tools/perf/tests/shell/test_brstack.sh

+12 −3
Original line number Diff line number Diff line
@@ -12,7 +12,6 @@ if ! perf record -o- --no-buildid --branch-filter any,save_type,u -- true > /dev 
fi



TMPDIR=$(mktemp -d /tmp/__perf_test.program.XXXXX)

TESTPROG="perf test -w brstack"



cleanup() {

	rm -rf $TMPDIR
@@ -20,11 +19,21 @@ cleanup() { 


trap cleanup EXIT TERM INT



is_arm64() {

	uname -m | grep -q aarch64

}



if is_arm64; then

	TESTPROG="perf test -w brstack 5000"

else

	TESTPROG="perf test -w brstack"

fi



test_user_branches() {

	echo "Testing user branch stack sampling"



	perf record -o $TMPDIR/perf.data --branch-filter any,save_type,u -- ${TESTPROG} > /dev/null 2>&1

	perf script -i $TMPDIR/perf.data --fields brstacksym | xargs -n1 > $TMPDIR/perf.script

	perf script -i $TMPDIR/perf.data --fields brstacksym | tr ' ' '\n' > $TMPDIR/perf.script



	# example of branch entries:

	# 	brstack_foo+0x14/brstack_bar+0x40/P/-/-/0/CALL
@@ -53,7 +62,7 @@ test_filter() { 
	echo "Testing branch stack filtering permutation ($test_filter_filter,$test_filter_expect)"



	perf record -o $TMPDIR/perf.data --branch-filter $test_filter_filter,save_type,u -- ${TESTPROG} > /dev/null 2>&1

	perf script -i $TMPDIR/perf.data --fields brstack | xargs -n1 > $TMPDIR/perf.script

	perf script -i $TMPDIR/perf.data --fields brstack | tr ' ' '\n' > $TMPDIR/perf.script



	# fail if we find any branch type that doesn't match any of the expected ones

	# also consider UNKNOWN branch types (-)