Unverified Commit b5934948 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!9607 enic: Validate length of nl attributes in enic_set_vf_port 

Merge Pull Request from: @ci-robot 
 
PR sync from: Yuan Can <yuancan@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/G5AFHD54EFAGT6X2CSMKPS6HRSXIFA7L/ 
 
https://gitee.com/src-openeuler/kernel/issues/IA7D2T 
 
Link:https://gitee.com/openeuler/kernel/pulls/9607

 

Reviewed-by: default avatarLiu YongQiang <liuyongqiang13@huawei.com>
Reviewed-by: default avatarYue Haibing <yuehaibing@huawei.com>
Reviewed-by: default avatarWeilong Chen <chenweilong@huawei.com>
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
parents f968c031 ec1aa076

drivers/net/ethernet/cisco/enic/enic_main.c

+12 −0
Original line number Diff line number Diff line
@@ -1152,18 +1152,30 @@ static int enic_set_vf_port(struct net_device *netdev, int vf, 
	pp->request = nla_get_u8(port[IFLA_PORT_REQUEST]);



	if (port[IFLA_PORT_PROFILE]) {

		if (nla_len(port[IFLA_PORT_PROFILE]) != PORT_PROFILE_MAX) {

			memcpy(pp, &prev_pp, sizeof(*pp));

			return -EINVAL;

		}

		pp->set |= ENIC_SET_NAME;

		memcpy(pp->name, nla_data(port[IFLA_PORT_PROFILE]),

			PORT_PROFILE_MAX);

	}



	if (port[IFLA_PORT_INSTANCE_UUID]) {

		if (nla_len(port[IFLA_PORT_INSTANCE_UUID]) != PORT_UUID_MAX) {

			memcpy(pp, &prev_pp, sizeof(*pp));

			return -EINVAL;

		}

		pp->set |= ENIC_SET_INSTANCE;

		memcpy(pp->instance_uuid,

			nla_data(port[IFLA_PORT_INSTANCE_UUID]), PORT_UUID_MAX);

	}



	if (port[IFLA_PORT_HOST_UUID]) {

		if (nla_len(port[IFLA_PORT_HOST_UUID]) != PORT_UUID_MAX) {

			memcpy(pp, &prev_pp, sizeof(*pp));

			return -EINVAL;

		}

		pp->set |= ENIC_SET_HOST;

		memcpy(pp->host_uuid,

			nla_data(port[IFLA_PORT_HOST_UUID]), PORT_UUID_MAX);