Commit b58eca40 authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo
Browse files

perf test: Parse events tidy terms_test 



Remove an unused variables. Make structs const. Fix checkpatch issue wrt
unsigned not being with an int.

Signed-off-by: default avatarIan Rogers <irogers@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Carsten Haitzler <carsten.haitzler@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.garry@huawei.com>
Cc: Marco Elver <elver@google.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Riccardo Mancini <rickyman7@gmail.com>
Cc: Sohaib Mohamed <sohaib.amhmd@gmail.com>
Cc: Stephane Eranian <eranian@google.com>
Link: https://lore.kernel.org/r/20220518042027.836799-6-irogers@google.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 7312c36c

tools/perf/tests/parse-events.c

+5 −7
Original line number Diff line number Diff line
@@ -1980,11 +1980,10 @@ static struct evlist_test test__events_pmu[] = { 


struct terms_test {

	const char *str;

	__u32 type;

	int (*check)(struct list_head *terms);

};



static struct terms_test test__terms[] = {

static const struct terms_test test__terms[] = {

	[0] = {

		.str   = "config=10,config1,config2=3,umask=1,read,r0xead",

		.check = test__checkterms_simple,
@@ -2112,7 +2111,7 @@ static int test_events(struct evlist_test *events, unsigned cnt) 
	return ret2;

}



static int test_term(struct terms_test *t)

static int test_term(const struct terms_test *t)

{

	struct list_head terms;

	int ret;
@@ -2139,13 +2138,12 @@ static int test_term(struct terms_test *t) 
	return ret;

}



static int test_terms(struct terms_test *terms, unsigned cnt)

static int test_terms(const struct terms_test *terms, int cnt)

{

	int ret = 0;

	unsigned i;



	for (i = 0; i < cnt; i++) {

		struct terms_test *t = &terms[i];

	for (int i = 0; i < cnt; i++) {

		const struct terms_test *t = &terms[i];



		pr_debug("running test %d '%s'\n", i, t->str);

		ret = test_term(t);