Commit b5438f48 authored by Chandrakanth Patil's avatar Chandrakanth Patil Committed by Martin K. Petersen
Browse files

scsi: megaraid_sas: Fix resource leak in case of probe failure 

The driver doesn't clean up all the allocated resources properly when
scsi_add_host(), megasas_start_aen() function fails during the PCI device
probe.

Clean up all those resources.

Link: https://lore.kernel.org/r/20210528131307.25683-3-chandrakanth.patil@broadcom.com


Signed-off-by: default avatarChandrakanth Patil <chandrakanth.patil@broadcom.com>
Signed-off-by: default avatarSumit Saxena <sumit.saxena@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 79db8301

drivers/scsi/megaraid/megaraid_sas_base.c

+13 −0
Original line number Diff line number Diff line
@@ -7545,11 +7545,16 @@ static int megasas_probe_one(struct pci_dev *pdev, 
	return 0;



fail_start_aen:

	instance->unload = 1;

	scsi_remove_host(instance->host);

fail_io_attach:

	megasas_mgmt_info.count--;

	megasas_mgmt_info.max_index--;

	megasas_mgmt_info.instance[megasas_mgmt_info.max_index] = NULL;



	if (instance->requestorId && !instance->skip_heartbeat_timer_del)

		del_timer_sync(&instance->sriov_heartbeat_timer);



	instance->instancet->disable_intr(instance);

	megasas_destroy_irqs(instance);
@@ -7557,8 +7562,16 @@ static int megasas_probe_one(struct pci_dev *pdev, 
		megasas_release_fusion(instance);

	else

		megasas_release_mfi(instance);



	if (instance->msix_vectors)

		pci_free_irq_vectors(instance->pdev);

	instance->msix_vectors = 0;



	if (instance->fw_crash_state != UNAVAILABLE)

		megasas_free_host_crash_buffer(instance);



	if (instance->adapter_type != MFI_SERIES)

		megasas_fusion_stop_watchdog(instance);

fail_init_mfi:

	scsi_host_put(host);

fail_alloc_instance:

drivers/scsi/megaraid/megaraid_sas_fusion.c

+1 −0
Original line number Diff line number Diff line
@@ -5272,6 +5272,7 @@ megasas_alloc_fusion_context(struct megasas_instance *instance) 
		if (!fusion->log_to_span) {

			dev_err(&instance->pdev->dev, "Failed from %s %d\n",

				__func__, __LINE__);

			kfree(instance->ctrl_context);

			return -ENOMEM;

		}

	}