Unverified Commit b541a6d5 authored by Javier Martinez Canillas's avatar Javier Martinez Canillas
Browse files

drm/panel-novatek-nt35950: Drop custom DSI write macro 



There is a macro for this already in the <drm/drm_mipi_dsi.h> header, use
that instead and delete the custom DSI write macro defined in the driver.

Signed-off-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230107191822.3787147-7-javierm@redhat.com
parent 0676f240

drivers/gpu/drm/panel/panel-novatek-nt35950.c

+3 −11
Original line number Diff line number Diff line
@@ -89,14 +89,6 @@ static inline struct nt35950 *to_nt35950(struct drm_panel *panel) 
	return container_of(panel, struct nt35950, panel);

}



#define dsi_dcs_write_seq(dsi, seq...) do {				\

		static const u8 d[] = { seq };				\

		int ret;						\

		ret = mipi_dsi_dcs_write_buffer(dsi, d, ARRAY_SIZE(d));	\

		if (ret < 0)						\

			return ret;					\

	} while (0)



static void nt35950_reset(struct nt35950 *nt)

{

	gpiod_set_value_cansleep(nt->reset_gpio, 1);
@@ -338,7 +330,7 @@ static int nt35950_on(struct nt35950 *nt) 
		return ret;



	/* Unknown command */

	dsi_dcs_write_seq(dsi, 0xd4, 0x88, 0x88);

	mipi_dsi_dcs_write_seq(dsi, 0xd4, 0x88, 0x88);



	/* CMD2 Page 7 */

	ret = nt35950_set_cmd2_page(nt, 7);
@@ -346,10 +338,10 @@ static int nt35950_on(struct nt35950 *nt) 
		return ret;



	/* Enable SubPixel Rendering */

	dsi_dcs_write_seq(dsi, MCS_PARAM_SPR_EN, 0x01);

	mipi_dsi_dcs_write_seq(dsi, MCS_PARAM_SPR_EN, 0x01);



	/* SPR Mode: YYG Rainbow-RGB */

	dsi_dcs_write_seq(dsi, MCS_PARAM_SPR_MODE, MCS_SPR_MODE_YYG_RAINBOW_RGB);

	mipi_dsi_dcs_write_seq(dsi, MCS_PARAM_SPR_MODE, MCS_SPR_MODE_YYG_RAINBOW_RGB);



	/* CMD3 */

	ret = nt35950_inject_black_image(nt);