Commit b5412827 authored Sep 29, 2021 by Yevgeny Kliteynik Committed by Saeed Mahameed Dec 31, 2021

net/mlx5: DR, Warn on failure to destroy objects due to refcount



Add WARN_ON_ONCE on refcount checks in SW steering object destructors

Signed-off-by: Paul Blakey <paulb@nvidia.com>
Signed-off-by: Yevgeny Kliteynik <kliteyn@nvidia.com>

parent e3a0f40b

drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1792,7 +1792,7 @@ mlx5dr_action_create_dest_vport(struct mlx5dr_domain *dmn,

		int mlx5dr_action_destroy(struct mlx5dr_action *action)
		{
		if (refcount_read(&action->refcount) > 1)
		if (WARN_ON_ONCE(refcount_read(&action->refcount) > 1))
		return -EBUSY;

		switch (action->action_type) {

drivers/net/ethernet/mellanox/mlx5/core/steering/dr_domain.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -431,7 +431,7 @@ int mlx5dr_domain_sync(struct mlx5dr_domain *dmn, u32 flags)

		int mlx5dr_domain_destroy(struct mlx5dr_domain *dmn)
		{
		if (refcount_read(&dmn->refcount) > 1)
		if (WARN_ON_ONCE(refcount_read(&dmn->refcount) > 1))
		return -EBUSY;

		/* make sure resources are not used by the hardware */

drivers/net/ethernet/mellanox/mlx5/core/steering/dr_matcher.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1069,7 +1069,7 @@ int mlx5dr_matcher_destroy(struct mlx5dr_matcher *matcher)
		{
		struct mlx5dr_table *tbl = matcher->tbl;

		if (refcount_read(&matcher->refcount) > 1)
		if (WARN_ON_ONCE(refcount_read(&matcher->refcount) > 1))
		return -EBUSY;

		mlx5dr_domain_lock(tbl->dmn);

drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -283,7 +283,7 @@ int mlx5dr_table_destroy(struct mlx5dr_table *tbl)
		{
		int ret;

		if (refcount_read(&tbl->refcount) > 1)
		if (WARN_ON_ONCE(refcount_read(&tbl->refcount) > 1))
		return -EBUSY;

		mlx5dr_dbg_tbl_del(tbl);