Commit b50675a4 authored Aug 01, 2023 by Kemeng Shi Committed by Theodore Ts'o Aug 03, 2023

ext4: return found group directly in ext4_mb_choose_next_group_goal_fast



Return good group when it's found in loop to remove futher check if good
group is found after loop.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Link: https://lore.kernel.org/r/20230801143204.2284343-9-shikemeng@huaweicloud.com


Signed-off-by: Theodore Ts'o <tytso@mit.edu>

parent f6c72fef

fs/ext4/mballoc.c

+6 −8

Original line number	Diff line number	Diff line
		@@ -959,16 +959,14 @@ static void ext4_mb_choose_next_group_goal_fast(struct ext4_allocation_context *
		for (i = mb_avg_fragment_size_order(ac->ac_sb, ac->ac_g_ex.fe_len);
		i < MB_NUM_ORDERS(ac->ac_sb); i++) {
		grp = ext4_mb_find_good_group_avg_frag_lists(ac, i);
		if (grp)
		break;
		}

		if (grp) {
		*group = grp->bb_group;
		ac->ac_flags \|= EXT4_MB_CR_GOAL_LEN_FAST_OPTIMIZED;
		} else {
		*new_cr = CR_BEST_AVAIL_LEN;
		return;
		}
		}

		*new_cr = CR_BEST_AVAIL_LEN;
		}

		/*