Commit b5050639 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Michael Ellerman
Browse files

powerpc/iommu: fix memory leak with using debugfs_lookup() 



When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.

Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20230202141919.2298821-1-gregkh@linuxfoundation.org
parent dcfecb98

arch/powerpc/kernel/iommu.c

+1 −3
Original line number Diff line number Diff line
@@ -67,11 +67,9 @@ static void iommu_debugfs_add(struct iommu_table *tbl) 
static void iommu_debugfs_del(struct iommu_table *tbl)

{

	char name[10];

	struct dentry *liobn_entry;



	sprintf(name, "%08lx", tbl->it_index);

	liobn_entry = debugfs_lookup(name, iommu_debugfs_dir);

	debugfs_remove(liobn_entry);

	debugfs_lookup_and_remove(name, iommu_debugfs_dir);

}

#else

static void iommu_debugfs_add(struct iommu_table *tbl){}