Commit b4eafca1 authored by Sasikantha babu's avatar Sasikantha babu Committed by Greg Kroah-Hartman
Browse files

sysfs: Removed dup_name entirely in sysfs_rename 



Since no one using "dup_name", removed it completely in sysfs_rename.

Signed-off-by: default avatarSasikantha babu <sasikanth.v19@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent eb157427

fs/sysfs/dir.c

+2 −4
Original line number Diff line number Diff line
@@ -858,7 +858,6 @@ int sysfs_rename(struct sysfs_dirent *sd, 
	struct sysfs_dirent *new_parent_sd, const void *new_ns,

	const char *new_name)

{

	const char *dup_name = NULL;

	int error;



	mutex_lock(&sysfs_mutex);
@@ -875,11 +874,11 @@ int sysfs_rename(struct sysfs_dirent *sd, 
	/* rename sysfs_dirent */

	if (strcmp(sd->s_name, new_name) != 0) {

		error = -ENOMEM;

		new_name = dup_name = kstrdup(new_name, GFP_KERNEL);

		new_name = kstrdup(new_name, GFP_KERNEL);

		if (!new_name)

			goto out;



		dup_name = sd->s_name;

		kfree(sd->s_name);

		sd->s_name = new_name;

	}
@@ -895,7 +894,6 @@ int sysfs_rename(struct sysfs_dirent *sd, 
	error = 0;

 out:

	mutex_unlock(&sysfs_mutex);

	kfree(dup_name);

	return error;

}