Commit b4e964f8 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

habanalabs/gaudi: Fix uninitialized return code rc when read size is zero 



In the case where size is zero the while loop never assigns rc and the
return value is uninitialized. Fix this by initializing rc to zero.

Fixes: 639781dc ("habanalabs/gaudi: add debugfs to DMA from the device")
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Uninitialized scalar variable")
Link: https://lore.kernel.org/r/20210412161012.1628202-1-colin.king@canonical.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 39d2a789

drivers/misc/habanalabs/gaudi/gaudi.c

+1 −1
Original line number Diff line number Diff line
@@ -6252,7 +6252,7 @@ static int gaudi_debugfs_read_dma(struct hl_device *hdev, u64 addr, u32 size, 
	dma_addr_t dma_addr;

	void *kernel_addr;

	bool is_eng_idle;

	int rc, dma_id;

	int rc = 0, dma_id;



	kernel_addr = hdev->asic_funcs->asic_dma_alloc_coherent(

						hdev, SZ_2M,