Commit b4d1d5c6 authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

media: venus: venus_helper_get_bufreq(): req is never NULL 



Fix a smatch error:

drivers/media/platform/qcom/venus/helpers.c: drivers/media/platform/qcom/venus/helpers.c:678 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 674)

After checking how venus_helper_get_bufreq() is called it is clear that
req is never NULL, so just drop the checks.

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarStanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 109670df

drivers/media/platform/qcom/venus/helpers.c

+2 −4
Original line number Diff line number Diff line
@@ -671,7 +671,6 @@ int venus_helper_get_bufreq(struct venus_inst *inst, u32 type, 
	unsigned int i;

	int ret;



	if (req)

	memset(req, 0, sizeof(*req));



	if (type == HFI_BUFFER_OUTPUT || type == HFI_BUFFER_OUTPUT2)
@@ -694,7 +693,6 @@ int venus_helper_get_bufreq(struct venus_inst *inst, u32 type, 
		if (hprop.bufreq[i].type != type)

			continue;



		if (req)

		memcpy(req, &hprop.bufreq[i], sizeof(*req));

		ret = 0;

		break;