Commit b4b221bd authored by Dan Carpenter's avatar Dan Carpenter Committed by Paolo Abeni
Browse files

net: ethernet: renesas: Fix return type in rswitch_etha_wait_link_verification() 



The rswitch_etha_wait_link_verification() is supposed to return zero
on success or negative error codes.  Unfortunately it is declared as a
bool so the caller treats everything as success.

Fixes: 3590918b ("net: ethernet: renesas: Add support for "Ethernet Switch"")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Link: https://lore.kernel.org/r/Y3OPo6AOL6PTvXFU@kili


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent b2e44aac

drivers/net/ethernet/renesas/rswitch.c

+1 −1
Original line number Diff line number Diff line
@@ -920,7 +920,7 @@ static void rswitch_etha_write_mac_address(struct rswitch_etha *etha, const u8 * 
		  etha->addr + MRMAC1);

}



static bool rswitch_etha_wait_link_verification(struct rswitch_etha *etha)

static int rswitch_etha_wait_link_verification(struct rswitch_etha *etha)

{

	iowrite32(MLVC_PLV, etha->addr + MLVC);